Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sorting to themes and prompts #19

Merged
merged 2 commits into from
May 1, 2024
Merged

Add sorting to themes and prompts #19

merged 2 commits into from
May 1, 2024

Conversation

driftingly
Copy link
Contributor

This PR adds sorting to themes and prompts.

  • Adds new app:cache-image-info to cache image data which will occasionally slow the generation of the cached JSON output.
  • Removes the limit(8) when eager loading the artworks
    • This can be added back once we upgrade to Laravel 11

2024-04-30 13 22 30
2024-04-30 13 23 02

@driftingly driftingly requested review from zachgarwood, nikhiltri and web-dev-trev and removed request for zachgarwood April 30, 2024 20:27
nikhiltri
nikhiltri approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@nikhiltri nikhiltri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ⭐

Confirmed that I can reorder themes and prompts, and that the new order is reflected in the JSON output.

zachgarwood
zachgarwood approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@zachgarwood zachgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🐴

app/Console/Commands/CacheImageInfo.php Show resolved Hide resolved
Base automatically changed from drift/qa-fixes to develop May 1, 2024 16:24
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@driftingly driftingly merged commit cb6e754 into develop May 1, 2024
2 checks passed
@driftingly driftingly deleted the drift/sort-prompts branch May 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgarwood zachgarwood zachgarwood approved these changes

@nikhiltri nikhiltri nikhiltri approved these changes

@web-dev-trev web-dev-trev Awaiting requested review from web-dev-trev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driftingly @nikhiltri @zachgarwood