Use errno.EISDIR and errno.EACCESS instead of hardcoding values #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows tests show failures with this change. I think both codes need to be kept. The Linux one can be replaced with |
|
Indeed Windows seems to rely on EACCES, added that as well. |
dktrkranz
changed the title
dktrkranz
changed the title
arsenetar
reviewed
Feb 19, 2024
| # the code we get on OS X and Linux, 13 is what we get on Windows. | ||
| if e.errno in {21, 13}: | ||
| # If our OSError is because dest is already a directory, we want to handle that. | ||
| if e.errno in (EISDIR, EACCES): |
There was a problem hiding this comment.
I do think maybe leaving the note about how different errors here are due to the different OSes would be helpful in the future. Same in the other file as well.
There was a problem hiding this comment.
Comments refactored as per suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.