-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional tests for the new banner and version verification. #400
Merged
MatousJobanek
merged 5 commits into
arquillian:functional-tests
from
hemanik:additional-tests
Nov 3, 2017
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9ee3e1f
Adds test to verify latest release for standalone module page.
hemanik 06d2aed
Adds test to verify New Announcement Banner.
hemanik 630a3d6
Adds test to verify latest release for modules page.
hemanik 32369cb
Updates test to verify absence of banner on new announcement.
hemanik 5ad401d
fix: navigate to drone blog page to verify old blogs.
hemanik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
src/test/java/org/arquillian/tests/utilities/GitHubProjectVersionExtractor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
package org.arquillian.tests.utilities; | ||
|
||
import com.google.gson.Gson; | ||
import com.google.gson.JsonArray; | ||
import com.google.gson.JsonElement; | ||
import org.apache.http.client.utils.URIBuilder; | ||
import org.jboss.arquillian.drone.webdriver.utils.HttpClient; | ||
|
||
public class GitHubProjectVersionExtractor { | ||
|
||
private String TAGS_URL = "/tags"; | ||
private String TAG_NAME = "name"; | ||
private String project; | ||
|
||
public GitHubProjectVersionExtractor(String project) { | ||
this.project = String.format("https://api.github.com/repos/arquillian/%s", project); | ||
} | ||
|
||
public String getLatestReleaseFromGitHub() { | ||
try { | ||
final HttpClient.Response response = sentGetRequestWithPagination(project + TAGS_URL, 1); | ||
JsonArray releaseTags = new Gson().fromJson(response.getPayload(), JsonElement.class).getAsJsonArray(); | ||
if (releaseTags.size() == 0) { | ||
return null; | ||
} | ||
return releaseTags.get(0).getAsJsonObject().get(TAG_NAME).getAsString(); | ||
} catch (Exception e) { | ||
throw new RuntimeException("Failed to fetch latest release from GitHub.", e); | ||
} | ||
} | ||
|
||
private HttpClient.Response sentGetRequestWithPagination(String url, int pageNumber) throws Exception { | ||
final URIBuilder uriBuilder = new URIBuilder(url); | ||
if (pageNumber != 1) { | ||
uriBuilder.setParameter("page", String.valueOf(pageNumber)); | ||
} | ||
return new HttpClient().get(uriBuilder.build().toString()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case the first page of the blog will contain only the latest versions/announcements, then the test will fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated