Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated things and replace Fabric8 Maven plugin with JKube maven plugin #1309

Merged
merged 15 commits into from
Aug 2, 2024

Conversation

jimma
Copy link
Collaborator

@jimma jimma commented Jun 27, 2024

Short description of what this resolves:

Remove deprecated things

Changes proposed in this pull request:

  • Remove the boot2docker module
  • Remove docker-machine
  • Remove docker-compose v1
  • Replace Fabric8 Maven plugin with JKube maven plugin
  • Remove doc about jboss forge addon, bootdocker and docker-machine

Fixes #1308

@jimma jimma force-pushed the main-deprecated branch 2 times, most recently from c575035 to 70bbc35 Compare July 4, 2024 03:53
@jimma jimma requested a review from fabiobrz July 24, 2024 02:18
@jimma jimma removed the in progress label Jul 24, 2024
@jimma jimma requested a review from gaol July 24, 2024 03:18
Copy link
Collaborator

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jimma - I had a quick look, and have just a minor comment, since I didn't dive in properly yet for a detailed code review.

In the meanwhile, I am asking whether we can deal with #1311 separately and I'd ask the same for the Fabric8 -> JKube Maven plugin (where maybe I could help, as well).

WDYT?

.circleci/config.yml Show resolved Hide resolved
README.adoc Show resolved Hide resolved
Copy link
Collaborator

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your work on these changes, @jimma
I've gone through the commits you added, and the incremental changes the introduce.
Regarding the boot2Docker and Docker Machine modules removal, I am fine with the changes and dropped just one question about a commented out block.

Again, regarding Fabric8 Maven plugin -> JKube Maven plugin, I am not sure I get the reasoning for not addressing it in a separate PR, but maybe I am missing something.
Could you please elaborate on this? I know we discussed the replacement in chat, but a dedicated issue/PR would be better IMHO.

Update: now I see that the related issue (#1308) is actually more generic, therefore the Fabric8->Jkube related changes could fit in here.
If that is the case @jimma - would you please change the PR title to either mention both boot2Docker and Fabric8 Maven plugin removal/replacement or none of them?

@jimma jimma changed the title Remove the deprecated boot2docker module Remove the deprecated things and replace Fabric8 Maven plugin with JKube maven plugin Jul 31, 2024
@jimma
Copy link
Collaborator Author

jimma commented Jul 31, 2024

Thanks @fabiobrz for the review again.

Copy link
Collaborator

@gaol gaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimma one minor comment on the latest tag usage in the DockerTemplate, others LGTM :)

containerless/src/test/resources/node/DockerfileTemplate Outdated Show resolved Hide resolved
fabiobrz
fabiobrz previously approved these changes Jul 31, 2024
Copy link
Collaborator

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimma - changes LGTM. Approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the deprecated stuff
3 participants