Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1178): Calculate and specify a wait-for-it timeout #1179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phillipross
Copy link

Short description of what this resolves:

When a container is configured with polling await strategy, the parameters for the strategy are used to compute a timeout and passed to the wait-for-it command.

Fixes #1178

@bartoszmajsak
Copy link
Member

Thanks for your contribution @phillipross. I guess I have to first fix the build (general problem, not PR related) and then we can move forward.

@phillipross
Copy link
Author

Yes, I had to disable OpenShift tests to get my builds to work. I don't have the expertise with OpenShift to determine the problem, but figured I should submit the PR anyway. Thanks!

@phillipross
Copy link
Author

@bartoszmajsak any progress on this? let me know if there's anything I can do to help move things alone. Thanks!

@bartoszmajsak
Copy link
Member

@bartoszmajsak any progress on this? let me know if there's anything I can do to help move things alone. Thanks!

Sorry @phillipross I didn't have time yet to look at build failures. If you have time and you are willing to dig into it that would be just awesome. I might be able to get into that later this week, but been pretty busy with other stuff lately :(

@phillipross
Copy link
Author

I understand, no problem 😉 I believe when I looked before it seemed to be issues with the openshift integration or something, but I'll take a closer look and see what I can uncover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PollingAwaitStrategy wait-for-it does fallback ignores parameters
2 participants