Better handling of deleted messages (Fixes #40) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* default is 30 days * New project dependency: `django-appconf`
* Job can now be called with no arguments: setting `MESSAGES_DELETED_MAX_AGE` is used * Or using previous behaviour (by passing a minimum age as an argument)
…_DELETED_MAX_AGE`
Internally we change the deleted_at date of a permanently deleted message to more than MESSAGES_DELETED_MAX_AGE days ago. If both users permanently deleted a message or if deleted_at is more than MESSAGES_DELETED_MAX_AGE days ago, the message is deleted from the database. Even if the message could not be deleted from the database (one of the users did not delete the message), the message will not appear in the trash anymore.
|
Thank you for the contribution. Looks good, but I'm against adding django-appconf as a dependency (I can remove this myself when merging). |
|
Just came back from holiday. Is there anything you want me to change before you can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MESSAGES_DELETED_MAX_AGEdays ago do not appear in the trash.If both users permanently deleted a message or if message was deleted more than
MESSAGES_DELETED_MAX_AGEdays ago, then the message is removed from the database (onpermanently_delete()call, onempty_trash()call or usingdelete_deleted_messages.py)New dependency to handle
MESSAGES_DELETED_MAX_AGEsetting: django-appconfnotificationpackage.