Optional pagination #135
Open
Optional pagination #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not using the Django sites framework, you get a RuntimeError because it is not installed, even if you set DJANGO_MESSAGES_NOTIFY to False. This can be avoided by importing the site model only when necessary.
By default, message list is not paginated, but now one can enable pagination by setting ``DJANGO_MESSAGES_PAGE_LENGTH`` to a positive integer. Pagination is disabled if this setting variable is not defined or set to -1.
Paginator.get_page() is only available in django >= 2.0, let's use Paginator.page() instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, message list is not paginated, but now one can enable pagination
by setting
DJANGO_MESSAGES_PAGE_LENGTHto a positive integer.Pagination is disabled if this setting variable is not defined or set to -1.