HTTPS en localhost #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite https development services
|
Linux est compatible, çà dépend du browser 😛 C'est firefox qui n'est pas compatible notamment |
Deploying votefinder-fr with
|
| Latest commit: |
3a0160f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2808319b.votefinder-fr.pages.dev |
| Branch Preview URL: | https://features-https-localhost.votefinder-fr.pages.dev |
arnaudsm
reviewed
Jun 26, 2024
frontend/vite.config.js
Outdated
|
|
||
| // https://vitejs.dev/config/ | ||
| export default defineConfig({ | ||
| plugins: [react(), svgr({ include: "**/*.svg" })], | ||
| plugins: [react(), mkcert(), svgr({ include: "**/*.svg" })], |
There was a problem hiding this comment.
Tu peux le rendre optionnel derrière une variable d'env (que tu peux rajouter dans une commande makefile) ? Ce package demande les droits administrateurs, ce qui est un no-go pour beaucoup de gens
Sous chromium + linux impossible de faire fonctionner dans mon cas : https://caniuse.com/web-share |
Striffly
force-pushed
the
features/https-localhost
branch
from
a94a3a6
to
7d1b9c4
Compare
arnaudsm
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilise notamment pour tester en local le bouton de partage
En effet pour avoir ce bouton il faut que plusieurs conditions soient respectés :
Bref dans mon cas c'est possible de tester cela que sur Android via le réseau local (donc adresse en 192.xxx). Donc obligé d'avoir le HTTPS