v1.4.0 prep - DO NOT MERGE #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two tests still pass even without the patching. That indicates that whatever is under test is not actually being tested or that the feature is broken. Additionally, there are better ways to patch settings during test and AUTH_PROFILE_MODULE was deprecated in Django 1.5.
…happening. The assumption was that users always have profiles and that's incorrect. From the 1.4 docs, "The method get_profile() does not create a profile if one does not exist." These users never have profiles so that's why the patching didn't matter and why the tests passed anyway.
…hat seems dangerously circular). Remove static test file, setting and url route for the removed "audio" component.
…t breaks testing).
- Sorl is already required in setup.py so we don't need it in dev.txt - Document that an imaging library is necessary for Sorl features. (We aren't testing anything that requires PIL so it's safe to remove that dev requirement.)
…e it isn't used. Update model-utils to minimum version for Django 1.5 and max version for Django 1.3.
…Django 1.4. Use standard method to override settings. Fixing: `Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored`
|
Let's discuss this groundwork and merge it in to the |
…we don't need magic to trick Django into making concrete model instances. This also means we can drop the concrete infrastructure in ArmDev.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet the complete 1.4.0 code, only the groundwork. There are a few more things I'll handle as separate PR's.
armstrong.apps.contentfor testsdjango-reversionrequirement, which was never usedAs additional PRs:
armstrong.apps.embedsI think we should do two quick releases. 1.4 will tie up loose ends and be the last version to support Django 1.3. 1.5 will support Django 1.5+ and maybe drop 1.4 support (two reasons:
django-taggitand the profile issue). Depending on how we solve the profile issue, we may need to break BC or at least break behavior. We can discuss more on the PR for that.