-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let firmware info be optional to save RAM #83
base: master
Are you sure you want to change the base?
Conversation
@armink any thoughts on this? |
These version number information seems to be necessary, and optimization is not recommended |
I agree that some system to track the version of product HW/SW version is necessary for most embedded systems but for example my company has been using CmBacktrace for many years but we already have our own version number mechanism and prefer not to have a duplicate system, thus it is not necessary for us and probably many other users. CmBacktrace works very well without version number tracking mechanism but your choice to take the PR or not. |
You can try to change |
d3b4a81
to
60cf01a
Compare
Why not have a weak symbol Also, why have these version strings live inside of RAM buffers in the first place? |
Many projects already have another mechanism for getting firmware info or want to save RAM and do not need firmware info of CmBacktrace. With this change user can pass NULL for name and version after setting the define CMB_NOT_USING_FIRMWARE_INFO.
60cf01a
to
38d923b
Compare
Both good points, I can explore making these suggested changes. |
Many projects already have another mechanism for getting firmware info or want to save RAM and do not need firmware info of CmBacktrace.