armbian-led-state: avoid binary parameters, other minor cleanups #7337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a led driver or trigger generates a parameter that contains binary or non-printable characters,
armbian-led-state-save.sh
stores the value that may contain null, carriage return or other non-textual characters that confusearmbian-led-state-restore.sh
. Don't store binary values in such case to prevent functionality breakage.Also moves the systemd dependency after
sysinit.target
, which seems to be a more reasonable place rather thantimers.target
GitHub issue reference:
Jira reference number AR-2505
How Has This Been Tested?
Checklist: