Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

armbian-led-state: avoid binary parameters, other minor cleanups #7337

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

paolosabatino
Copy link
Contributor

@paolosabatino paolosabatino commented Oct 5, 2024

Description

When a led driver or trigger generates a parameter that contains binary or non-printable characters, armbian-led-state-save.sh stores the value that may contain null, carriage return or other non-textual characters that confuse armbian-led-state-restore.sh. Don't store binary values in such case to prevent functionality breakage.

Also moves the systemd dependency after sysinit.target, which seems to be a more reasonable place rather than timers.target

GitHub issue reference:
Jira reference number AR-2505

How Has This Been Tested?

  • Tested on a live system against various led triggers and drivers (USB keyboard, ledtrig_netdev kernel module, tm16xx driver display pseudo-led that creates the offending binary parameter quoted in description)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@paolosabatino paolosabatino requested a review from a team as a code owner October 5, 2024 13:06
@github-actions github-actions bot added size/small PR with less then 50 lines BSP Board Support Packages labels Oct 5, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 11 Milestone: Fourth quarter release labels Oct 6, 2024
@igorpecovnik igorpecovnik merged commit 2960ffa into armbian:main Oct 6, 2024
13 checks passed
@paolosabatino paolosabatino deleted the armbian-led-state-fixes branch October 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release BSP Board Support Packages Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants