OP5+/HDMIRX: Allow ability to restream without reopening device #7257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/small
|
You should be able to add "ready to merge" label. When you feel its good to go. |
|
I jumped the gun on this one, this was a bug in my userspace code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I couldn't "restream" on the hdmirx driver for OPi5+. Meaning once I had opened the hdmirx device, called start stream, then stopped the stream, and then tried to start the stream again without closing the file/device, I would get a "device busy" code. The error/busy signal is thrown from this line of code. Looking at the function call for
vb2_is_busythestream->buf_queuejust needs to be marked as done.I'm not sure what this function
return_all_bufferswas doing before, but this patch marks items as done before delete them and use a helper method in the kernel to iterate the list instead of hand-rolling the logic.This patch has been submitted to collabora for upstreaming.
How Has This Been Tested?
Tested on OP5+
Checklist:
Please delete options that are not relevant.