Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Op5+/HDMI-RX: expose ITC type to v4l2 in synopsys hdmir rx #7224

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

benhoff
Copy link
Collaborator

@benhoff benhoff commented Sep 13, 2024

Description

This exposes the ITC content type provided by hdmi spec to v4l2. This allows user space applications to query the driver using V4L2_CID_DV_RX_IT_CONTENT_TYPE. This way user applications can see not only if a hdmi is plugged in or not, but also what type of video is being transmitted.

For my use case specifically, I just want to know if the recieved type is no type (V4L2_DV_IT_CONTENT_TYPE_NO_ITC) or literally anything else.

This would let me detect when my main computer's goes to sleep with the hdmi out from the main computer plugged into the OP5+ HDMI in.

Without this patch, there's no way to tell that happened, as for my gpu/hdmi plug, it keeps the hot plug detection pin high the whole time.

How Has This Been Tested?

tested on orange pi 5 plus

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Sep 13, 2024
@benhoff benhoff changed the title expose itc type to v4l2 in synopsys hdmir rx Op5+/HDMI-RX: expose itc type to v4l2 in synopsys hdmir rx Sep 13, 2024
@amazingfate
Copy link
Contributor

It's better to contact Shreeya Patel <[email protected]> who is the author of the mainline patch to see if this change is upstreamable.

@benhoff benhoff changed the title Op5+/HDMI-RX: expose itc type to v4l2 in synopsys hdmir rx Op5+/HDMI-RX: expose ITC type to v4l2 in synopsys hdmir rx Sep 13, 2024
@benhoff
Copy link
Collaborator Author

benhoff commented Sep 13, 2024

It's better to contact Shreeya Patel <[email protected]> who is the author of the mainline patch to see if this change is upstreamable.

@amazingfate , I have been emailing her and others on the Collabora team the patchsets that I'm trying to apply to Armbian for this driver.

They have not replied so far. It's only been a day or two, they are probably busy.

I'll keep trying to get this upstreamed.

I'd also like to get this integrated to Armbian if possible as it's the build platform that I'm leveraging for this work.

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Sep 13, 2024
@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress 11 Milestone: Fourth quarter release labels Sep 14, 2024
@benhoff benhoff force-pushed the patch3 branch 2 times, most recently from 96bfa22 to 8abf328 Compare September 15, 2024 19:07
@github-actions github-actions bot added size/small PR with less then 50 lines and removed size/medium PR with more then 50 and less then 250 lines labels Sep 15, 2024
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Sep 15, 2024
@benhoff benhoff added Ready to merge Reviewed, tested and ready for merge Build Executing build train (permission needed) and removed Work in progress Unfinished / work in progress labels Sep 23, 2024
@igorpecovnik igorpecovnik merged commit ee46889 into armbian:main Sep 30, 2024
12 of 13 checks passed
@rpardini
Copy link
Member

rpardini commented Oct 2, 2024

Hmm, seems to me this landed to the 6.10 directory after 6.11 was bumped.
Please review and send PR also for 6.11 or this will be lost like tears in the rain...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Build Executing build train (permission needed) Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

4 participants