fix: Wasm compilation for wasm32-wasi target #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After forcing `wasmer-wasix` to use the `js` feature when the `circom-compat/js` feature is enabled. As well as forcing `wasmer/js` and otherwise, `wasmer/default`. The crate can now successfully compile to wasm. Resolves: arkworks-rs#73
|
cc: @mmagician this should make it into |
mmagician
approved these changes
Aug 23, 2024
|
There is some weird issue with clippy it seems, the fix it suggests is incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After forcing
wasmer-wasixto use thejsfeature when thecircom-compat/jsfeature is enabled. As well as forcingwasmer/jsand otherwise,wasmer/default. The crate can now successfully compile to wasm.Resolves: #73