-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyInstaller & Dynamic Versioning Support #40
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces support for PyInstaller and dynamic versioning in the pymusiclooper project. The changes involve moving the versioning logic from the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @arkrow - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
pymusiclooper/__version__.py
Outdated
@@ -0,0 +1,2 @@ | |||
# Dynamically updated by poetry-dynamic-versioning | |||
__version__ = "0.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Hardcoded version number
Hardcoding the version number as 0.0.0
might lead to confusion or errors if the version is not updated properly. Consider using a script or tool to dynamically update this value to reflect the actual version of the package.
__version__ = "0.0.0" | |
import pkg_resources | |
__version__ = pkg_resources.get_distribution("pymusiclooper").version |
This reverts commit 358c518.
Summary by Sourcery
Replaced static versioning with dynamic versioning using poetry-dynamic-versioning by moving version definition from pymusiclooper/init.py to pymusiclooper/version.py.