Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyInstaller & Dynamic Versioning Support #40

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

arkrow
Copy link
Owner

@arkrow arkrow commented Jul 16, 2024

Summary by Sourcery

Replaced static versioning with dynamic versioning using poetry-dynamic-versioning by moving version definition from pymusiclooper/init.py to pymusiclooper/version.py.

Copy link

sourcery-ai bot commented Jul 16, 2024

Reviewer's Guide by Sourcery

This pull request introduces support for PyInstaller and dynamic versioning in the pymusiclooper project. The changes involve moving the versioning logic from the __init__.py file to a new __version__.py file, which will be dynamically updated by the poetry-dynamic-versioning tool.

File-Level Changes

Files Changes
pymusiclooper/__init__.py
pymusiclooper/__version__.py
Refactored versioning logic to support dynamic versioning with poetry-dynamic-versioning by moving it from __init__.py to a new __version__.py file.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arkrow - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -0,0 +1,2 @@
# Dynamically updated by poetry-dynamic-versioning
__version__ = "0.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Hardcoded version number

Hardcoding the version number as 0.0.0 might lead to confusion or errors if the version is not updated properly. Consider using a script or tool to dynamically update this value to reflect the actual version of the package.

Suggested change
__version__ = "0.0.0"
import pkg_resources
__version__ = pkg_resources.get_distribution("pymusiclooper").version

@arkrow arkrow mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant