Skip to content

Commit

Permalink
Fix non-deterministic error when resetting a parent workflow with a c…
Browse files Browse the repository at this point in the history
…hild workflow

Includes the following change from cadence: uber-go/cadence-client#1118
Fixes the following community issue: : temporalio#723
  • Loading branch information
arithran committed Jul 22, 2024
1 parent 1350fb4 commit ee34197
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion internal/internal_event_handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,11 @@ func (wc *workflowEnvironmentImpl) ExecuteChildWorkflow(
params ExecuteWorkflowParams, callback ResultHandler, startedHandler func(r WorkflowExecution, e error),
) {
if params.WorkflowID == "" {
params.WorkflowID = wc.workflowInfo.WorkflowExecution.RunID + "_" + wc.GenerateSequenceID()
if wc.workflowInfo.OriginalRunID != "" {
params.WorkflowID = wc.workflowInfo.OriginalRunID + "_" + wc.GenerateSequenceID()
} else {
params.WorkflowID = wc.workflowInfo.WorkflowExecution.RunID + "_" + wc.GenerateSequenceID()
}
}
memo, err := getWorkflowMemo(params.Memo, wc.dataConverter)
if err != nil {
Expand Down

0 comments on commit ee34197

Please sign in to comment.