Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add switchport 'tap' and 'tool' mode config to the ethernet and port-channel interfaces #4174

Open
wants to merge 27 commits into
base: devel
Choose a base branch
from
Open

Feat(eos_cli_config_gen): Add switchport 'tap' and 'tool' mode config to the ethernet and port-channel interfaces #4174

wants to merge 27 commits into from

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jul 2, 2024 •
edited
Loading

Change Summary

Add switchport 'tap' and 'tool' mode config to the interfaces

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add schema, template and tests for switchport.tap and switchport.tool in interfaces.

How to test

Molecule test added. Test in EOS CLI.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4174
# Activate the virtual environment
source test-avd-pr-4174/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@switchport_tap_tool#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,switchport_tap_tool --force
# Optional: Install AVD examples
cd test-avd-pr-4174
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 2, 2024
@Shivani-gslab Shivani-gslab mentioned this pull request Jul 2, 2024
Merged
4 tasks
MaheshGSLAB
MaheshGSLAB reviewed Jul 10, 2024
View reviewed changes
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/ethernet-interfaces.md Show resolved Hide resolved
...lections/arista/avd/molecule/eos_cli_config_gen/intended/configs/port-channel-interfaces.cfg Outdated Show resolved Hide resolved
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 15, 2024 12:05
@Shivani-gslab Shivani-gslab requested review from a team as code owners July 15, 2024 12:05
@Shivani-gslab Shivani-gslab marked this pull request as draft July 21, 2024 17:24
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 22, 2024 12:38
@Shivani-gslab Shivani-gslab marked this pull request as draft July 22, 2024 13:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Shivani-gslab Shivani-gslab marked this pull request as draft November 7, 2024 10:47
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the state: conflict PR with conflict label Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Shivani-gslab
Copy link
Contributor Author

Moving hostvars in PR #4697

@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 11, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review November 11, 2024 13:43
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 11, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 13, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

ClausHolbechArista
ClausHolbechArista reviewed Nov 15, 2024
View reviewed changes
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml Outdated
description: MAC address for the source.
dest:
type: str
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid the required here if we can just check for it in the template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
`encapsulation.vxlan_strip` and `mpls_pop_all` are mutually exclusive.
`mpls_pop_all` takes precedence.
gre:
type: list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could any of the fields be a primary_key?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there could be commands like this -

   switchport tap encapsulation gre protocol 0x3 strip
   switchport tap encapsulation gre strip
   switchport tap encapsulation gre destination 1.1.1.1 protocol 0x0 strip
   switchport tap encapsulation gre destination 1.1.1.2 protocol 0xffff strip
   switchport tap encapsulation gre destination 1.1.1.3 protocol 0x2 strip
   switchport tap encapsulation gre destination 1.1.1.4 protocol 0x1 strip

Copy link
Contributor Author

@Shivani-gslab Shivani-gslab Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored the code to fix ordering!

@Shivani-gslab Shivani-gslab marked this pull request as draft November 18, 2024 05:52
@Shivani-gslab Shivani-gslab marked this pull request as ready for review November 18, 2024 06:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista requested changes

@laxmikantchintakindi laxmikantchintakindi laxmikantchintakindi approved these changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@Vibhu-gslab Vibhu-gslab Awaiting requested review from Vibhu-gslab

@alexeygorbunov alexeygorbunov Awaiting requested review from alexeygorbunov

Requested changes must be addressed to merge this pull request.

Assignees

@Shivani-gslab Shivani-gslab

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Shivani-gslab @ClausHolbechArista @Vibhu-gslab @MaheshGSLAB @laxmikantchintakindi @carlbuchmann