-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add support to enable ISIS authentication at global level #4102
base: devel
Are you sure you want to change the base?
Feat(eos_designs): Add support to enable ISIS authentication at global level #4102
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4102
# Activate the virtual environment
source test-avd-pr-4102/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@isis_authentication#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,isis_authentication --force
# Optional: Install AVD examples
cd test-avd-pr-4102
ansible-playbook arista.avd.install_examples |
Quality Gate passedIssues Measures |
ansible_collections/arista/avd/roles/eos_designs/docs/tables/isis-settings.md
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
716702e
to
1a92d94
Compare
1a92d94
to
782bf18
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
2708fd7
to
1a92d94
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1a92d94
to
fca2efd
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
c942dba
to
491e7c0
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
The change for eos_cli_config_gen has been merged now. |
Quality Gate passedIssues Measures |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
Quality Gate passedIssues Measures |
Change Summary
Add support to enable ISIS authentication at global level.
Related Issue(s)
Fixes #3674
Component(s) name
arista.avd.eos_designs
Proposed changes
ISIS authentication is not enabled by default when enabling ISIS as the underlay protocol for the fabric. It would be great to have a global knob to enable authentication in the fabric links like we do for BGP.
How to test
Add underlay_isis_authentication_mode and underlay_isis_authentication_key at global level.
Checklist
User Checklist
Repository Checklist