Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add support to enable ISIS authentication at global level #4102

Draft
wants to merge 23 commits into
base: devel
Choose a base branch
from

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Jun 12, 2024

Change Summary

Add support to enable ISIS authentication at global level.

Related Issue(s)

Fixes #3674

Component(s) name

arista.avd.eos_designs

Proposed changes

ISIS authentication is not enabled by default when enabling ISIS as the underlay protocol for the fabric. It would be great to have a global knob to enable authentication in the fabric links like we do for BGP.

How to test

Add underlay_isis_authentication_mode and underlay_isis_authentication_key at global level.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4102
# Activate the virtual environment
source test-avd-pr-4102/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@isis_authentication#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,isis_authentication --force
# Optional: Install AVD examples
cd test-avd-pr-4102
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jun 12, 2024
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review June 14, 2024 06:58
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft June 14, 2024 16:13
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jun 17, 2024
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Jun 18, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 18, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 18, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added state: conflict PR with conflict and removed state: conflict PR with conflict role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Jun 18, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: conflict PR with conflict labels Jun 19, 2024
Copy link

github-actions bot commented Aug 5, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 5, 2024
@ClausHolbechArista
Copy link
Contributor

The change for eos_cli_config_gen has been merged now.

Copy link

sonarcloud bot commented Aug 20, 2024

@github-actions github-actions bot added the state: conflict PR with conflict label Sep 30, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Nov 15, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 18, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

sonarcloud bot commented Nov 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ISIS global knob to enable authentication
4 participants