-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: no automatic foreign keys referencing partitions #3114
Open
s-sokolko
wants to merge
28
commits into
ariga:master
Choose a base branch
from
s-sokolko:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icats Feature: no automatic foreign keys referencing partitions
Thanks for the contribution, @s-sokolko. However, I won’t merge this as it conflicts with our current work on supporting partitions (which should be released soon). I appreciate your effort. |
This reverts commit c2c3c24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
atlas migrate diff
and the schema contains partitioned tables the autogenerated migration sometimes contains duplicate foreign key constraints. It happens when there is a foreign key in DB schema that references a partitioned table. In this case the foreign key search sql filters tables by the source table of the FK only, But we have to filter also by the target table, because if we don't the query also gives us all the partitions of tha partitioned table aprat from the partitioned table itself.I've faced this situation using Postgres. My fix adds checks and some query formatting.