Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gormschema: support view #45

Merged
merged 31 commits into from
May 17, 2024
Merged

gormschema: support view #45

merged 31 commits into from
May 17, 2024

Conversation

luantranminh
Copy link
Collaborator

implements #38

@a8m a8m self-requested a review May 8, 2024 16:48
giautm
giautm reviewed May 8, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
giautm
giautm reviewed May 8, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
a8m
a8m reviewed May 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
a8m
a8m reviewed May 8, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
a8m
a8m reviewed May 8, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
@luantranminh luantranminh marked this pull request as draft May 9, 2024 17:43
giautm
giautm reviewed May 12, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
gormschema/gorm.go Outdated Show resolved Hide resolved
@luantranminh @giautm
refactor: lint
2435015 
Co-authored-by: Giau. Tran Minh <[email protected]>
a8m
a8m reviewed May 13, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
@luantranminh luantranminh marked this pull request as ready for review May 14, 2024 13:55
a8m
a8m reviewed May 15, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
a8m
a8m reviewed May 15, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
a8m
a8m reviewed May 15, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
giautm
giautm reviewed May 16, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
giautm
giautm reviewed May 16, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
a8m
a8m reviewed May 16, 2024
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides some minor doc comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@giautm giautm requested a review from a8m May 17, 2024 06:56
a8m
a8m reviewed May 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
a8m
a8m reviewed May 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
a8m
a8m reviewed May 17, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
a8m
a8m reviewed May 17, 2024
View reviewed changes
gormschema/gorm.go Outdated Show resolved Hide resolved
a8m
a8m approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments before merging.

@giautm giautm merged commit 797a13b into ariga:master May 17, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giautm giautm giautm approved these changes

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luantranminh @a8m @giautm