Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong params in test #41

Closed

Conversation

luantranminh
Copy link
Collaborator

@luantranminh luantranminh commented Apr 20, 2024

Function definition is:

https://github.com/stretchr/testify/blob/bb548d0473d4e1c9b7bbfd6602c7bf12f7a84dd2/require/require.go#L155

func Equal(t TestingT, expected interface{}, actual interface{}, msgAndArgs ...interface)

content from file should be expected result, not actual result

@luantranminh
Copy link
Collaborator Author

image
image

@ronenlu
Copy link
Member

ronenlu commented Apr 21, 2024

image image

@luantranminh its because your forked repo is lacking some secret, I will create identical PR from this repo

@luantranminh
Copy link
Collaborator Author

Oh, weird. Does it mean I followed the wrong steps to make a PR?

@ronenlu ronenlu mentioned this pull request Apr 21, 2024
@ronenlu
Copy link
Member

ronenlu commented Apr 21, 2024

Oh, weird. Does it mean I followed the wrong steps to make a PR?

no, you did everything ok.
Just when forking repo, you dont fork the secrets.
and 1 of the secret is used to run the integration tests, thus the GH action fail.

@luantranminh
Copy link
Collaborator Author

duplicated #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants