Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlasexec: support list for variables #82

Merged
merged 1 commit into from
Aug 6, 2024
Merged

atlasexec: support list for variables #82

merged 1 commit into from
Aug 6, 2024

Conversation

giautm
Copy link
Member

@giautm giautm commented Aug 6, 2024

No description provided.

Vars map[string]string
// Vars2 is a map of variables for the command.
// It supports multiple values for the same key (list).
Vars2 map[string]any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Vars2 map[string]any
VarsSlice map[string][]string

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use any to accept raw JSON from some environment, like GH Actions or CircleCI

@giautm giautm merged commit 4999cdd into master Aug 6, 2024
3 checks passed
@giautm giautm deleted the g/vars-list branch August 6, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants