atlasaction: support migrate/apply #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
||||||||||||||||
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
||||||||||||||||
dorav
reviewed
Sep 26, 2023
atlasaction/action.go
Outdated
Comment on lines
40
to
41
| // Cloud-based migrations are currently based on creating a temporary atlas.hcl | ||
| // file therefore it cannot be used with a user-supplied config. |
There was a problem hiding this comment.
Is it implemented this way because of the override of cloud-url and cloud-token?
If so, I think this should be solved in the testing code, not inside the production code and causing a limitation on the users
dorav
reviewed
Sep 26, 2023
dorav
reviewed
Sep 26, 2023
atlasaction/action.go
Outdated
Comment on lines
39
to
40
| if strings.HasPrefix(params.DirURL, "atlas://") && params.Env != "" && params.ConfigURL == "" { | ||
| cfg, clean, err := atlasexec.TempFile(`env { name = atlas.env }`, "hcl") |
There was a problem hiding this comment.
- If there is an env name but no URL, there might be a missing parameter (a human error) on the side of the user, in which case we might perform the wrong operation (apply a migration with a wrong parameter for example)?
If that's the case, I think throwing an error is safer and more predictable (and should probably be done by Atlas / Nebula, since we agreed the actions should do minimal logic)
- Why is that needed for reporting the run to the cloud? the user provided the migration directory
- What happens if the user didn't provide an 'env' name? will we get a report to the cloud?
dorav
reviewed
Sep 26, 2023
| } | ||
| t.Run("basic", func(t *testing.T) { | ||
| var payloads []string | ||
| srv := httptest.NewServer(handler(&payloads)) |
dorav
approved these changes
Sep 26, 2023
a8m
reviewed
Sep 26, 2023
atlasaction/action_test.go
Outdated
| dir := testDir(t, "./testdata/migrations") | ||
| ad, err := migrate.ArchiveDir(&dir) | ||
| require.NoError(t, err) | ||
| // nolint:errcheck |
There was a problem hiding this comment.
a8m
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.