Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema/plan/approve: distinct action for approve the plan #229

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

giautm
Copy link
Member

@giautm giautm commented Sep 18, 2024

No description provided.

Copy link

Atlas Lint Report

Analyzed migrations

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

Atlas Lint Report

Analyzed migrations2

StatusStepResultDiagnostics
Detect New Migration FilesFound 0 new migration files (from 0 total)
Replay Migration FilesLoaded 0 changes on dev database
Connect your project to Atlas Cloud to get more safety checks

Migrations automatically reviewed by Atlas

Copy link

github-actions bot commented Sep 18, 2024

atlas migrate lint on atlasaction/testdata/migrations_destructive

Status Step Result
1 new migration file detected 20230925192914.sql
ERD and visual diff generated View Visualization
Analyze 20230925192914.sql
1 reports were found in analysis
Destructive changes detected
Dropping table "t1" (DS102)
Read the full linting report on Atlas Cloud

Copy link

github-actions bot commented Sep 18, 2024

Atlas detected changes to the desired schema

SQL Plan

-- Create "t1" table
CREATE TABLE `t1` (
  `c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
  `c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
  `c1` integer NOT NULL
);
-- Create "t4" table
CREATE TABLE `t4` (
  `c1` integer NOT NULL,
  `c2` integer NOT NULL
);

Atlas lint results

Status Step Result
Detect schema changes4 new statements detected
No issues found

📝 To edit this plan, follow these steps
  1. Run atlas schema plan pull --url "atlas://atlas-action/plans/pr-227-R1cGcSfo" > pr-227-R1cGcSfo.plan.hcl
  2. Modify the plan.
  3. Push the plan using atlas schema plan push --pending --env test --file pr-227-R1cGcSfo.plan.hcl
  4. Re-trigger this action using gh run rerun 10929226056

@giautm giautm force-pushed the g/schema-plan-approve branch 5 times, most recently from c78354d to e1da448 Compare September 18, 2024 19:53
@giautm giautm merged commit 83741f5 into master Sep 19, 2024
18 checks passed
@giautm giautm deleted the g/schema-plan-approve branch September 19, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants