atlasaction: allow config approver users on the action #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atlas Lint ReportAnalyzed migrations2
Migrations automatically reviewed by Atlas |
||||||||||||||||
|
|
||||||||||||||||
Atlas Lint ReportAnalyzed migrations
Migrations automatically reviewed by Atlas |
||||||||||||||||
Atlas detected changes to the desired schemaSQL Plan-- Create "t1" table
CREATE TABLE `t1` (
`c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
`c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
`c1` integer NOT NULL,
`c2` integer NOT NULL
);
-- Create "t4" table
CREATE TABLE `t4` (
`c1` integer NOT NULL,
`c2` integer NOT NULL
);
Atlas lint results
To edit this plan, follow these steps:
|
giautm
force-pushed
the
g/plan-approval
branch
from
355b2aa
to
d6825ae
Compare
Atlas detected changes to the desired schemaSQL Plan-- Create "t1" table
CREATE TABLE `t1` (
`c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
`c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
`c1` integer NOT NULL
);
-- Create "t4" table
CREATE TABLE `t4` (
`c1` integer NOT NULL,
`c2` integer NOT NULL
);Atlas lint results
📝 To edit this plan, follow these steps
|
giautm
force-pushed
the
g/plan-approval
branch
from
d6825ae
to
b48c456
Compare
Atlas detected changes to the desired schemaSQL Plan-- Create "t1" table
CREATE TABLE `t1` (
`c1` integer NOT NULL
);
-- Create "t2" table
CREATE TABLE `t2` (
`c1` integer NOT NULL
);
-- Create "t3" table
CREATE TABLE `t3` (
`c1` integer NOT NULL
);
-- Create "t4" table
CREATE TABLE `t4` (
`c1` integer NOT NULL,
`c2` integer NOT NULL
);Atlas lint results
📝 To edit this plan, follow these steps
|
giautm
force-pushed
the
g/plan-approval
branch
from
b48c456
to
8abfdc9
Compare
giautm
force-pushed
the
g/plan-approval
branch
from
8abfdc9
to
7642e8d
Compare
giautm
commented
Sep 20, 2024
Comment on lines
+715
to
+728
| comments, err := c.getIssueComments(ctx, pr) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get the pull request comments: %w", err) | ||
| } | ||
| approved := slices.IndexFunc(comments, func(c githubIssueComment) bool { | ||
| if c.AuthorHasAccess() && c.HasCommand(triggerComment) { | ||
| return len(approvers) == 0 || slices.Contains(approvers, c.Author()) | ||
| } | ||
| return false | ||
| }) | ||
| if approved == -1 { | ||
| a.Errorf("Please comment %q on the pull request to approve the action: %s", triggerComment, pr.URL) | ||
| return errors.New("Approval checks failed") | ||
| } |
There was a problem hiding this comment.
Adding a polling loop here to fetch comments, so it will hold the action until the user comments on the issue to approve this action,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.