fix(modal): cleanup and update snapshots

ariellalgilmore · Dec 14, 2023 · 735d850 · 735d850
1 parent ad605e3
commit 735d850
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 14 deletions.
diff --git a/packages/carbon-web-components/src/components/modal/modal-close-button.ts b/packages/carbon-web-components/src/components/modal/modal-close-button.ts
@@ -32,7 +32,7 @@ class CDSModalCloseButton extends FocusMixin(LitElement) {
   closeButtonLabel = 'Close';
 
   updated() {
-    this.parentElement.setAttribute('close-button', '');
+    this.parentElement?.setAttribute('close-button', '');
   }
 
   render() {

diff --git a/packages/carbon-web-components/src/components/modal/modal-footer.ts b/packages/carbon-web-components/src/components/modal/modal-footer.ts
@@ -40,8 +40,8 @@ class CDSModalFooter extends LitElement {
       ).length;
     this.hasThreeButtons = length > 2;
     length === 2
-      ? this.parentElement.setAttribute('has-two-buttons', '')
-      : this.parentElement.removeAttribute('has-two-buttons');
+      ? this.parentElement?.setAttribute('has-two-buttons', '')
+      : this.parentElement?.removeAttribute('has-two-buttons');
     this.requestUpdate();
   }
 

diff --git a/packages/carbon-web-components/src/components/modal/modal-header.ts b/packages/carbon-web-components/src/components/modal/modal-header.ts
@@ -46,9 +46,9 @@ class CDSModalHeader extends LitElement {
 
   updated() {
     if (this._hasSlug) {
-      this.parentElement.setAttribute('slug', '');
+      this.parentElement?.setAttribute('slug', '');
     } else {
-      this.parentElement!.removeAttribute('slug');
+      this.parentElement?.removeAttribute('slug');
     }
   }
 

diff --git a/packages/carbon-web-components/tests/snapshots/cds-checkbox.md b/packages/carbon-web-components/tests/snapshots/cds-checkbox.md
@@ -6,7 +6,7 @@
 
 ```
 <input
-  aria-checked="false"
+  aria-checked="true"
   aria-readonly="false"
   class="cds--checkbox"
   id="checkbox"
@@ -20,19 +20,21 @@
   title=""
 >
   <span class="cds--checkbox-label-text">
-    <slot>
-      Checkbox label
-    </slot>
+    Checkbox label
   </span>
 </label>
+<slot name="slug">
+</slot>
+<div class="cds--checkbox__validation-msg">
+</div>
 
 ```
 
 ####   `Should render with various attributes`
 
 ```
 <input
-  aria-checked="mixed"
+  aria-checked="true"
   aria-readonly="false"
   class="cds--checkbox"
   disabled=""
@@ -46,12 +48,14 @@
   part="label"
   title=""
 >
-  <span class="cds--checkbox-label-text cds--visually-hidden">
-    <slot>
-      label-text-foo
-    </slot>
+  <span class="cds--checkbox-label-text">
+    Checkbox label
   </span>
 </label>
+<slot name="slug">
+</slot>
+<div class="cds--checkbox__validation-msg">
+</div>
 
 ```