Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Algorithm from 'COURSE BIDDING AT BUSINESS SCHOOLS' #9

Merged
merged 22 commits into from
Sep 19, 2024

Conversation

zachibs
Copy link
Contributor

@zachibs zachibs commented Jul 15, 2024

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

יש רק קובץ אחד - לא צריך לשים אותו בתיקיה נפרדת - אפשר לשים אותו בתיקיה הראשית algorithms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tie_braking_lottery=tie_braking_lottery)


def test_large_input():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

בנוסף לבדיקה הזאת, צריך גם בדיקה על קלט גדול שנוצר באקראי. אפשר להשתמש בפונקציה Instance.uniform_random

from typing import Dict, List, Union

import logging
logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(name)s - %(levelname)s - %(message)s')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

אתחול הפורמט של הלוגר מתבצע בתוכנית הראשית ולא כאן.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


import logging
logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(name)s - %(levelname)s - %(message)s')
logger = logging.getLogger(__name__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

רק השורה הזאת אמורה להיות כאן.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger = logging.getLogger(__name__)


def sort_and_tie_brake(input_dict: Dict[str, float], tie_braking_lottery: Dict[str, float]) -> List[tuple[str, float]]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

שגיאת כתיב: tie-brake צריך להיות tie-break (מופיע בהרבה מקומות לאורך הקוד)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erelsgl erelsgl merged commit 813c1e2 into ariel-research:main Sep 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants