-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Algorithm from 'COURSE BIDDING AT BUSINESS SCHOOLS' #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
יש רק קובץ אחד - לא צריך לשים אותו בתיקיה נפרדת - אפשר לשים אותו בתיקיה הראשית algorithms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
תוקן בקומיט refactor: logging, naming and naive course order
tie_braking_lottery=tie_braking_lottery) | ||
|
||
|
||
def test_large_input(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
בנוסף לבדיקה הזאת, צריך גם בדיקה על קלט גדול שנוצר באקראי. אפשר להשתמש בפונקציה Instance.uniform_random
from typing import Dict, List, Union | ||
|
||
import logging | ||
logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(name)s - %(levelname)s - %(message)s') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
אתחול הפורמט של הלוגר מתבצע בתוכנית הראשית ולא כאן.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
תוקן בקומיט refactor: logging, naming and naive course order
|
||
import logging | ||
logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(name)s - %(levelname)s - %(message)s') | ||
logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
רק השורה הזאת אמורה להיות כאן.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
תוקן בקומיט refactor: logging, naming and naive course order
logger = logging.getLogger(__name__) | ||
|
||
|
||
def sort_and_tie_brake(input_dict: Dict[str, float], tie_braking_lottery: Dict[str, float]) -> List[tuple[str, float]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
שגיאת כתיב: tie-brake צריך להיות tie-break (מופיע בהרבה מקומות לאורך הקוד)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
תוקן בקומיט refactor: logging, naming and naive course order
No description provided.