naor #8
Merged
naor #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Naorl98
commented
Jul 5, 2024
Naorl98
commented
- naorr
# Conflicts: # fairpyx/algorithms/high_multiplicity_fair_allocation.py
# Conflicts: # fairpyx/algorithms/high_multiplicity_fair_allocation.py
# Conflicts: # fairpyx/algorithms/high_multiplicity_fair_allocation.py
# Conflicts: # requirements.txt
erelsgl
reviewed
Jul 25, 2024
setup.py
Outdated
There was a problem hiding this comment.
The setup file should not change.
requirements.txt
Outdated
There was a problem hiding this comment.
The requirements file should not change.
| for i in range(num_agents): | ||
| for j in range(num_items): | ||
| # Constraint 7 - inequality (7) in the paper. | ||
| constraint7 = allocation_variables[i][j] + delta[i][j] <= -1 + (2 * items_capacities[j]) * (1 - Z[i][j]) |
There was a problem hiding this comment.
"(2 * items_capacities[j]) " should be "(2 * items_capacities[j] + 1)"
(bug fix by the paper author)
elorisraeli
reviewed
Jul 26, 2024
| @@ -10,4 +10,4 @@ prtpy | |||
| # cvxpy_leximin>=0.4.4 | |||
| # prtpy>=0.7.0 | |||
| # more_itertools | |||
| # scs | |||
| # scs | |||
There was a problem hiding this comment.
Its seems like it changed - but it not changed at all, this is the same code in the same line (13).
This is weird but this is the same code so it will not do anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.