Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Video Capture #741

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Support Video Capture #741

merged 6 commits into from
Jul 24, 2024

Conversation

AntumDeluge
Copy link
Member

@AntumDeluge AntumDeluge commented Jun 10, 2024

Adds video capture of viewport & audio capture of page.

🛠️ Tasks

  • video capture
    • support capturing viewport only
    • support capturing entire page (will be added in different PR)
    • allow custom framerate if possible in WebAPI (will be added in different PR)
    • allow alternative codecs/containers such as MP4, OGG, etc. (may be browser dependent) (currently only WEBM is supported as tested in Firefox on Windows) (will be added in different PR)
  • audio capture (may need to change sound manager to utilize AudioContext) (will be added in different PR)
    • it may require all audio being played from a single source
  • slash action to start/stop
  • menu button to start/stop

Completed features will be merged to master as alpha features. Remaining features will be added in a new PR or directly to master.

Related to #733

@AntumDeluge AntumDeluge self-assigned this Jun 10, 2024
@AntumDeluge AntumDeluge force-pushed the screencap branch 5 times, most recently from 24fb0b4 to 539ebb1 Compare June 12, 2024 23:54
@AntumDeluge AntumDeluge mentioned this pull request Jul 2, 2024
13 tasks
@AntumDeluge AntumDeluge force-pushed the screencap branch 2 times, most recently from 4bf0f99 to 6ca668b Compare July 15, 2024 17:12
@AntumDeluge AntumDeluge added this to the 1.48 milestone Jul 24, 2024
@AntumDeluge AntumDeluge changed the title Support Video/Audio Capture Support Video Jul 24, 2024
@AntumDeluge AntumDeluge marked this pull request as ready for review July 24, 2024 00:33
@AntumDeluge AntumDeluge changed the title Support Video Support Video Capture Jul 24, 2024
@AntumDeluge AntumDeluge merged commit 38c71e2 into arianne:master Jul 24, 2024
3 checks passed
@AntumDeluge AntumDeluge deleted the screencap branch July 24, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant