Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kika Clouds Gatekeeper #707

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f4b3ce3
Generic event
AntumDeluge May 18, 2024
1d2ea89
Add support for generic events in web client
AntumDeluge May 18, 2024
62684eb
Add support for generic events in Java client
AntumDeluge May 18, 2024
c18d98e
Punishment for visiting Kika clouds too frequently
AntumDeluge Apr 20, 2024
8733167
Add sound effect to balloon when popped
AntumDeluge May 3, 2024
77f25db
Louder thunderclap for kika punishment
AntumDeluge May 10, 2024
e51b84c
Web client effect for Kika punishment
AntumDeluge May 11, 2024
f180638
Requests made to enter clouds within cooldown period do not count as...
AntumDeluge May 18, 2024
7040554
Remove the more punishing aspects of the Kika gatekeeper
AntumDeluge May 18, 2024
fbf7cbb
Change slot from "heaven_gatekeeper" to "kika_gatekeeper"
AntumDeluge May 18, 2024
7b2e257
Increase time between first & second notification
AntumDeluge May 18, 2024
83a4096
Fix import
AntumDeluge May 18, 2024
d685807
Rename KikaPunishmentEvent to ThunderclapEvent
AntumDeluge May 18, 2024
a78bfe3
Remove redundant text in message
AntumDeluge May 18, 2024
acab6bf
Change notification type
AntumDeluge May 18, 2024
66fe39b
Use thunderclap event
AntumDeluge May 18, 2024
d52c695
Don't play global sound for thunderclap event
AntumDeluge May 18, 2024
ee929af
Rename ViewPort.onDrawComplete to ViewPort.onSceneComplete
AntumDeluge May 18, 2024
c573e35
Set SubEvent flags in constructor
AntumDeluge May 18, 2024
9174ecc
Update thunderclap event for changes to SubEvent class
AntumDeluge May 18, 2024
ffe1124
Add wrapper methods to play sounds in Java client
AntumDeluge May 18, 2024
c95774d
Add optional callable to execute instructions after scene...
AntumDeluge May 18, 2024
a3034ad
Add support for thunderclap event to Java client
AntumDeluge May 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't play global sound for thunderclap event
AntumDeluge committed Jul 24, 2024

Verified

This commit was signed with the committer’s verified signature.
AntumDeluge Jordan Irwin
commit d52c695c8121b38c9ec31bb00bc2ba14ea3d4cdd
6 changes: 2 additions & 4 deletions src/js/stendhal/event/generic/ThunderclapEvent.ts
Original file line number Diff line number Diff line change
@@ -27,9 +27,6 @@ import { ViewPort } from "../../ui/ViewPort";

/**
* Creates a thunder & lightning effect.
*
* TODO:
* - maybe make thunderclap louder
*/
export class ThunderclapEvent extends SubEvent {

@@ -44,7 +41,8 @@ export class ThunderclapEvent extends SubEvent {
this.flash = flags.indexOf("no-flash") < 0;
this.lightning = flags.indexOf("no-lightning") < 0;
// thunder sound
SoundManager.get().playGlobalizedEffect(SoundID["thunderclap"]!, SoundLayer.SFX.value);
SoundManager.get().playLocalizedEffect(entity["x"], entity["y"], SoundManager.DEFAULT_RADIUS,
SoundLayer.SFX.value, SoundID["thunderclap"]!);
if (this.flash || this.lightning) {
// lightning visual effect
const viewport = ViewPort.get();