Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JailedDwarfTest #580

Merged
merged 2 commits into from
Feb 1, 2024
Merged

JailedDwarfTest #580

merged 2 commits into from
Feb 1, 2024

Conversation

twiernik
Copy link
Contributor

#549

Question: Quest is marked as repeatable, is that correct?

@AntumDeluge
Copy link
Member

Question: Quest is marked as repeatable, is that correct?

I can see in the source code that the argument passed to AbstractQuest.fillQuestInfo claims that it is. But that appears to be an error as the quest is not repeatable. As far as I can tell, that should be changed to pass false. But I would need to look further into the code to see what it affects.

@AntumDeluge AntumDeluge merged commit cefbd43 into arianne:master Feb 1, 2024
3 checks passed
@AntumDeluge AntumDeluge mentioned this pull request Feb 1, 2024
Open
28 tasks
@AntumDeluge
Copy link
Member

Question: Quest is marked as repeatable, is that correct?

Fortunately, that parameter doesn't affect anything in that particular quest. So it is safe to change.

AntumDeluge added a commit that referenced this pull request Feb 1, 2024
@AntumDeluge
Fix Jailed Dwarf quest erroneously marked as repeatable
bb08896 
#580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twiernik @AntumDeluge