Limit drawn parallax tiles to prevent potential infinite loop

arianne · May 28, 2024 · bcacec3 · bcacec3
1 parent f7321aa
commit bcacec3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/js/stendhal/landscape/ParallaxBackground.ts b/src/js/stendhal/landscape/ParallaxBackground.ts
@@ -64,9 +64,9 @@ export class ParallaxBackground {
 
 		const tileLeftStart = offsetX - ((offsetX / 4) % this.image.width);
 		let tileTop = offsetY - ((offsetY / 4) % this.image.height);
-		while (tileTop - offsetY < ctx.canvas.height) {
+		for (let yidx = 0; yidx < 100 && tileTop - offsetY < ctx.canvas.height; yidx++) {
 			let tileLeft = tileLeftStart;
-			while (tileLeft - offsetX < ctx.canvas.width) {
+			for (let xidx = 0; xidx < 100 && tileLeft - offsetX < ctx.canvas.width; xidx++) {
 				ctx.drawImage(this.image, tileLeft, tileTop);
 				tileLeft += this.image.width;
 			}