Move common ghost attributes to base class

arianne · Oct 8, 2023 · a66ec38 · a66ec38
1 parent 3d8def1
commit a66ec38
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 18 deletions.
diff --git a/src/games/stendhal/server/entity/npc/GhostNPCBase.java b/src/games/stendhal/server/entity/npc/GhostNPCBase.java
@@ -35,6 +35,13 @@ public abstract class GhostNPCBase extends SpeakerNPC {
 
 	public GhostNPCBase(final String name) {
 		super(name);
+
+		setResistance(0);
+		setVisibility(50);
+		// ghosts don't cast shadows
+		put("no_shadow", "");
+		// hide location from website
+		put("hidezone", "");
 	}
 
 	@Override

diff --git a/src/games/stendhal/server/maps/athor/cave/GhostNPC.java b/src/games/stendhal/server/maps/athor/cave/GhostNPC.java
@@ -80,17 +80,11 @@ protected void createPath() {
 		};
 
 		ghost.setDescription("You see a ghostly figure of a woman.");
-		ghost.setResistance(0);
 		ghost.setEntityClass("woman_005_npc");
-		// she is a ghost so she is see through
-		ghost.setVisibility(50);
 		ghost.setPosition(65, 74);
 		// she has low HP
 		ghost.initHP(30);
 		ghost.setBaseHP(100);
-		ghost.put("no_shadow", "");
-		// hide location from website
-		ghost.put("hidezone", "");
 		zone.add(ghost);
 	}
 }
diff --git a/src/games/stendhal/server/maps/orril/dungeon/GhostNPC.java b/src/games/stendhal/server/maps/orril/dungeon/GhostNPC.java
@@ -62,17 +62,11 @@ protected void createPath() {
 		};
 
 		ghost.setDescription("You see a ghostly figure of a man. He appears to have died in battle.");
-		ghost.setResistance(0);
 		ghost.setEntityClass("deadmannpc");
-		// he is a ghost so he is see through
-		ghost.setVisibility(70);
 		ghost.setPosition(216, 127);
 		// he has low HP
 		ghost.initHP(30);
 		ghost.setBaseHP(100);
-		ghost.put("no_shadow", "");
-		// hide location from website
-		ghost.put("hidezone", "");
 		zone.add(ghost);
 	}
 }
diff --git a/src/games/stendhal/server/maps/wofol/house5/GhostNPC.java b/src/games/stendhal/server/maps/wofol/house5/GhostNPC.java
@@ -62,17 +62,11 @@ protected void createPath() {
 		};
 
 		ghost.setDescription("You see a ghostly figure of a man. You have no idea how he died.");
-		ghost.setResistance(0);
 		ghost.setEntityClass("man_000_npc");
-		// he is a ghost so he is see through
-		ghost.setVisibility(50);
 		ghost.setPosition(3, 4);
 		// he has low HP
 		ghost.initHP(30);
 		ghost.setBaseHP(100);
-		ghost.put("no_shadow", "");
-		// hide location from website
-		ghost.put("hidezone", "");
 		zone.add(ghost);
 	}
 }