Release 5.5.0 #92
Merged
Release 5.5.0 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytasv
reviewed
Dec 14, 2023
| @@ -20,10 +20,10 @@ apply plugin: 'com.android.library' | |||
|
|
|||
| apply plugin: 'kotlin-android' | |||
|
|
|||
| def DEFAULT_COMPILE_SDK_VERSION = 33 | |||
| def DEFAULT_COMPILE_SDK_VERSION = 34 | |||
There was a problem hiding this comment.
When we release new version we just need to bump these numbers? Just wondering about other 2 DEFAULT_BUILD_TOOLS_VERSION and DEFAULT_MIN_SDK_VERSION when are those bumped?
There was a problem hiding this comment.
@bytasv These are mirrored from underlying native Android SDK. We are bumping these occasionally, when new Android SDK version ships for forward compatibility. More info.
minSdkVersion is the min version we support, we track this via BI and I guess the normal strategy is bumping it once there are no clients on that version and/or we really need some features that are not supported by some min SDK version.
But normally we just bump the native module version and that's it, eg. 5.4.0 -> 5.5.0
bytasv
approved these changes
Dec 14, 2023
viktorasl
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.