Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add automated benchmark report #302

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

ci: Add automated benchmark report #302

wants to merge 15 commits into from

Conversation

samuelburnham
Copy link
Member

@samuelburnham samuelburnham commented Oct 25, 2024

  • Updates manual benchmark workflow to run on a schedule, which runs all of the benchmarks every week
  • Improves report units for proving and verifying time (60000 -> 1min0s)
  • Upgrades to a custom Warpbuild r7iz.metal-32xl runner

Successful runs:

TODOs

  • Reuse code between jobs
  • Test thoroughly after merge

@tchataigner
Copy link
Member

tchataigner commented Oct 25, 2024

The fialure of the benchmark comes from the fact that the Sphinx logger was not enabled on Eth and KDA benchmarks. Activating the logger and running with log level info creates a 5 seconds overhead. I believe this is alright as the benchmarks will still give agood idea of the current performances, and we can run them without the logger for releases.

@tchataigner tchataigner force-pushed the ci-bench branch 3 times, most recently from 8abb90c to 4f707ec Compare October 26, 2024 11:58
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, and I love the Zulip posts! Thank you so much for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants