Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable end2end tests on forked PRs #37

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

samuelburnham
Copy link
Member

This PR enables end-to-end tests to run on forked PRs with the following triggers:

  • issue_comment: When a maintainer comments !test on a PR, it will trigger the end-to-end tests with full access to repo secrets. This enables the maintainer to carefully review PR comments before approving tests, without having to locally checkout and merge separately. This step is meant to give an early signal rather than be a required status check, so trivial or unrelated PRs can skip it.
  • merge_group: This triggers the end-to-end tests whenever a PR is added to the merge queue, which this repo doesn't currently have but is used to great effect in https://github.com/lurk-lab/lurk-rs. Requiring the tests to pass when attempting to merge ensures correctness if the above PR comment action isn't run.

Successful runs:

TODO:

  • Factor out end-to-end test into separate action to remove code duplication

@storojs72 storojs72 self-requested a review October 31, 2023 17:12
@storojs72
Copy link
Member

!test

@samuelburnham
Copy link
Member Author

@storojs72 The issue_comment trigger runs from the base branch, so unfortunately it's not possible to test until the action is merged to main and a new PR is opened. Please review the linked successful run carefully so we have confidence that this approach will work

@storojs72 storojs72 merged commit 02f5519 into argumentcomputer:main Oct 31, 2023
2 checks passed
samuelburnham added a commit to samuelburnham/solidity-verifier that referenced this pull request Feb 5, 2024
* Enable end2end tests on forked PRs (argumentcomputer#37)

* Test forked PR (argumentcomputer#38)

* ci: Switch to Buildjet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants