ci: use reuseable workflows #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
reusable-ci
branch
from
4a508db
to
3e7dc01
Compare
|
Hmm, I forgot to remove the part of the CI workflow that runs the doctests, which makes the failure of https://github.com/lurk-lab/neptune/actions/runs/7294189991/job/19878612122?pr=255 weird. |
|
This is the line that makes this tricky, reduced the PR to something simpler for now: |
huitseeker
force-pushed
the
reusable-ci
branch
from
3e7dc01
to
258cdf1
Compare
samuelburnham
requested changes
Dec 22, 2023
| - uses: actions/checkout@v4 | ||
| with: | ||
| repository: lurk-lab/ci-workflows | ||
| - uses: ./.github/actions/ci-env |
There was a problem hiding this comment.
We can also use the gpu-setup action to cut down on more lines in both the cuda and opencl jobs
There was a problem hiding this comment.
That's definitely the next step!
|
|
huitseeker
force-pushed
the
reusable-ci
branch
2 times, most recently
from
6bbb7f7
to
ca5617a
Compare
huitseeker
force-pushed
the
reusable-ci
branch
from
ca5617a
to
09e133e
Compare
samuelburnham
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.