Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update for latest Sphinx #298

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: Update for latest Sphinx #298

wants to merge 2 commits into from

Conversation

wwared
Copy link
Member

@wwared wwared commented Sep 10, 2024

Companion PR for argumentcomputer/sphinx#164
Companion PR for argumentcomputer/sphinx#186

A handful of minor changes to be cleaned up later:

  • MachineAir needs to be 'static + Send + Sync, which meant removing many references in Lair structs
  • The prove method is now a part of DefaultProver
  • We apparently need to shard before proving

Consider this commit as "something that works" rather than "something good", a short list of things to clean up in follow-ups:

  • Re-add sharing between Funcs, Toplevel, etc
  • Factor out prove/verify code into our own Prover types
  • Explicit sharding support in the prover

NOTE: Should be merged after argumentcomputer/sphinx#186 and updating the branch references in Cargo.toml

arthurpaulino
arthurpaulino previously approved these changes Sep 10, 2024
@wwared wwared marked this pull request as ready for review October 17, 2024 15:34
@wwared wwared changed the title chore: Update for Sphinx v1.0.0-rc.1 chore: Update for latest Sphinx Oct 17, 2024
@wwared wwared marked this pull request as draft October 21, 2024 16:29
A handful of minor changes to be cleaned up later:

* `MachineAir` needs to be `'static + Send + Sync`, which meant removing
many references in Lair structs
* The `prove` method is now a part of `DefaultProver`
* We apparently need to shard before proving

Consider this commit as "something that works" rather than "something
good", a short list of things to clean up in follow-ups:

* Re-add sharing between Funcs, Toplevel, etc
* Factor out prove/verify code into our own Prover types
* Explicit sharding support in the prover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants