chore: Update for latest Sphinx #298
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
previously approved these changes
Sep 10, 2024
wwared
force-pushed
the
update-sphinx-fp44
branch
from
4904b94
to
1806ac7
Compare
wwared
changed the title
wwared
force-pushed
the
update-sphinx-fp44
branch
from
1806ac7
to
1ca1410
Compare
A handful of minor changes to be cleaned up later: * `MachineAir` needs to be `'static + Send + Sync`, which meant removing many references in Lair structs * The `prove` method is now a part of `DefaultProver` * We apparently need to shard before proving Consider this commit as "something that works" rather than "something good", a short list of things to clean up in follow-ups: * Re-add sharing between Funcs, Toplevel, etc * Factor out prove/verify code into our own Prover types * Explicit sharding support in the prover
huitseeker
force-pushed
the
update-sphinx-fp44
branch
from
1ca1410
to
c20fd0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for argumentcomputer/sphinx#164Companion PR for argumentcomputer/sphinx#186
A handful of minor changes to be cleaned up later:
MachineAirneeds to be'static + Send + Sync, which meant removing many references in Lair structsprovemethod is now a part ofDefaultProverConsider this commit as "something that works" rather than "something good", a short list of things to clean up in follow-ups:
NOTE: Should be merged after argumentcomputer/sphinx#186 and updating the branch references in Cargo.toml