wrap verifier calls in catch_unwind #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the Rust FFI calls from panicking and terminating the program with
SIGABRT
. Instead the verifier indicates an unsuccessful validation to the caller.It is still the obligation of the caller to insure that the arguments are valid non-null null-terminated C-strings.
I would consider it a preliminary solution. Ideally, the verifier should return an error code (and/or possibly a message) on failure that that indicates what went wrong and allows the application to provide meaningful feedback to the user. (e.g. "invalid input encoding" vs. "proof validation failed").