chore: refine Coprocessors' API #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow coprocessor to alloc their own global constants * Remove Coprocessor::eval_arity since the implementer already defines CoCircuit::arity
arthurpaulino
commented
Feb 28, 2024
Comment on lines
+4075
to
+4099
| #[test] | ||
| fn test_hello_world_lang() { | ||
| use crate::coprocessor::test::HelloWorld; | ||
|
|
||
| let mut lang = Lang::<Fr, HelloWorld<Fr>>::new(); | ||
| let hello_world = HelloWorld::new(); | ||
| let name = user_sym("hello-world"); | ||
|
|
||
| let s = &Store::default(); | ||
| lang.add_coprocessor(name, hello_world); | ||
|
|
||
| let res = HelloWorld::intern_hello_world(s); | ||
| let terminal = s.cont_terminal(); | ||
|
|
||
| test_aux::<_, HelloWorld<_>>( | ||
| s, | ||
| "(hello-world)", | ||
| Some(res), | ||
| None, | ||
| Some(terminal), | ||
| None, | ||
| &expect!["1"], | ||
| &Some(lang.into()), | ||
| ); | ||
| } |
There was a problem hiding this comment.
This test wouldn't pass without the new alloc_globals
gabriel-barrett
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
LGTM. I have to say though, that GlobalAllocator could eventually be completely eliminated. A variable that is constrained to be a constant is really a waste, since we already have one such variable: one. Any other constant variable can be derived from this by a simple linear combination: the constant multiplied by the variable one. This is the third point in #1051
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #979