Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gpu-ci workflow #18

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Improve gpu-ci workflow #18

merged 2 commits into from
Jan 12, 2024

Conversation

samuelburnham
Copy link
Member

@samuelburnham samuelburnham commented Jan 11, 2024

This should work with lurk-rs, arecibo, neptune, and grumpkin-msm. The last may need some tweaks once GPU CI lands in argumentcomputer/grumpkin-msm#9 or similar.

Comment on lines 12 to 21
# Nextest profile specified in `.config/nextest.toml`
nextest-profile:
required: false
default: "default"
type: string
# Cargo profile specified in `Cargo.toml`
cargo-profile:
required: false
default: "release"
type: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not against this in principle, but I think we've kept it uniformly to one choice across our repos. Did you notice otherwise?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have either for neptune and no cargo-profile for grumpkin-msm, but I agree I'd rather enforce these patterns for our repos than make them inputs. Will remove

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/gpu-ci.yml Outdated Show resolved Hide resolved
.github/workflows/gpu-ci.yml Show resolved Hide resolved
@samuelburnham samuelburnham added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit 632871f Jan 12, 2024
@samuelburnham samuelburnham deleted the gpu-ci branch January 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants