Improve gpu-ci workflow
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
reviewed
Jan 11, 2024
.github/workflows/gpu-ci.yml
Outdated
Comment on lines
12
to
21
| # Nextest profile specified in `.config/nextest.toml` | ||
| nextest-profile: | ||
| required: false | ||
| default: "default" | ||
| type: string | ||
| # Cargo profile specified in `Cargo.toml` | ||
| cargo-profile: | ||
| required: false | ||
| default: "release" | ||
| type: string |
There was a problem hiding this comment.
I'm not against this in principle, but I think we've kept it uniformly to one choice across our repos. Did you notice otherwise?
There was a problem hiding this comment.
We don't have either for neptune and no cargo-profile for grumpkin-msm, but I agree I'd rather enforce these patterns for our repos than make them inputs. Will remove
There was a problem hiding this comment.
For the record, I'm ok with either way of managing this. But:
huitseeker
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work with
lurk-rs,arecibo,neptune, andgrumpkin-msm. The last may need some tweaks once GPU CI lands in argumentcomputer/grumpkin-msm#9 or similar.