Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 3.5 Swagger UI should reference 3.5 OpenAPI spec -- 3.5 specific #13824

Merged

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Oct 27, 2024

Fixes "Future Work" part 2 of #13818

Motivation

As we have versioned docs now (#11390), the Swagger UI should reference the OpenAPI spec of its release, not main

Modifications

In swagger.md, change the raw GH URL from main to release-3.5

Verification

  1. mkdocs build && open site/swagger/index.html
  2. Confirmed that it loads the Swagger UI properly and loads the release-3.5 spec.
    Screenshot: Screenshot 2024-10-26 at 11 40 00 PM

Notes to Reviewers

This PR is specific to the release-3.5 branch

  • will need to modify this upon backport to release-3.4

- this PR is specific to the `release-3.5` branch
  - will modify this upon backport to `release-3.4`

Signed-off-by: Anton Gilgur <[email protected]>
@agilgur5 agilgur5 added area/docs Incorrect, missing, or mistakes in docs type/backport Backport of an existing PR to an older release branch labels Oct 27, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Oct 28, 2024
@Joibel Joibel merged commit ac40195 into argoproj:release-3.5 Oct 31, 2024
10 checks passed
@agilgur5 agilgur5 deleted the docs-swagger-ui-ref-3.5-branch branch October 31, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs type/backport Backport of an existing PR to an older release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants