fix(dag): Running hooks should be able to refer to output of earlier tasks

[chengjoey]

Fixes #13619

Motivation

running task in a dag template don't have outputs, scope has earlier tasks outputs

resolveExitTmplArgument will check if outputs is empty, so we don't need to check it upstream of the function

argo-workflows/workflow/controller/exit_handler.go

Lines 54 to 71 in 2dac126

	func (woc *wfOperationCtx) resolveExitTmplArgument(args wfv1.Arguments, prefix string, outputs *wfv1.Outputs, scope *wfScope) (wfv1.Arguments, error) {
	if scope == nil {
	scope = createScope(nil)
	}
	if outputs != nil {
	for _, param := range outputs.Parameters {
	value := ""
	if param.Value != nil {
	value = param.Value.String()
	}
	scope.addParamToScope(fmt.Sprintf("%s.outputs.parameters.%s", prefix, param.Name), value)
	}
	for _, arts := range outputs.Artifacts {
	scope.addArtifactToScope(fmt.Sprintf("%s.outputs.artifacts.%s", prefix, arts.Name), arts)
	}
	}
	stepBytes, err := json.Marshal(args)

[agilgur5]

Nice find!

Can you add a test or two (negative and positive case) for this?

Also please note how I changed the title of your PR -- the PR commit should state what it does, not the problem. The issue states the problem, the PR states the fix

[agilgur5]

Also @chengjoey would you be interested in becoming an Argoproj Member? I can sponsor you and I'm sure we can get another sponsor too. Appreciate your contributions and hope to see more!

[chengjoey]

Can you add a test or two (negative and positive case) for this?

okay, i will add tests soon

[chengjoey]

Also @chengjoey would you be interested in becoming an Argoproj Member? I can sponsor you and I'm sure we can get another sponsor too. Appreciate your contributions and hope to see more!

yeah, thanks! @agilgur5

[chengjoey]

Can you add a test or two (negative and positive case) for this?

done~