docs: update CHANGELOG.md for v3.4.17 #13043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
terrytangyuan
approved these changes
May 13, 2024
agilgur5
changed the title
agilgur5
reviewed
May 22, 2024
There was a problem hiding this comment.
@terrytangyuan @isubasinghe It looks like some fixes to 3.5 features landed in 3.4.17, which aren't applicable to 3.4. Should we revert these all for 3.4.18?
See my in-line comments below for specific ones
| * [4f8dd2ee7](https://github.com/argoproj/argo-workflows/commit/4f8dd2ee7d716ba2fc9e08edd013acb66bc9494c) fix: artifact subdir error when using volumeMount (#12638) | ||
| * [3cd016b00](https://github.com/argoproj/argo-workflows/commit/3cd016b004fbc57360b8b23989fc492ae7dd4313) fix: Allow valueFrom in dag arguments parameters. Fixes #11900 (#11902) | ||
| * [c15a75b00](https://github.com/argoproj/argo-workflows/commit/c15a75b0076a6a69be0d0f0efb4c6129d3732ec5) fix(resources): improve ressource accounting. Fixes #12468 (#12492) | ||
| * [83a49b4b9](https://github.com/argoproj/argo-workflows/commit/83a49b4b9638b160c9320cd0e808179c31482ee5) fix: upgrade expr-lang. Fixes #12037 (#12573) |
There was a problem hiding this comment.
This was referenced May 22, 2024
agilgur5
pushed a commit
that referenced
this pull request
May 27, 2024
Signed-off-by: GitHub <[email protected]> Signed-off-by: Yuan Tang <[email protected]> Co-authored-by: terrytangyuan <[email protected]> Co-authored-by: Yuan Tang <[email protected]> (cherry picked from commit 026b14e)
agilgur5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action