feat(ui): allow to display date in absolute format #12986
Conversation
| @@ -13,7 +13,7 @@ export function Timestamp({date}: {date: Date | string | number}) { | |||
| '-' | |||
| ) : ( | |||
| <span title={tooltip(date)}> | |||
| <Ticker intervalMs={1000}>{() => ago(new Date(date))}</Ticker> | |||
| <Ticker intervalMs={1000}>{() => (displayFullDate ? new Date(date).toISOString() : ago(new Date(date)))}</Ticker> | |||
There was a problem hiding this comment.
This displays how long ago a date was, not the date itself. If anything you'd want to do this conversion on the date after ago
| @@ -3,7 +3,7 @@ import * as React from 'react'; | |||
|
|
|||
| import {ago} from '../duration'; | |||
|
|
|||
| export function Timestamp({date}: {date: Date | string | number}) { | |||
| export function Timestamp({date, displayFullDate = false}: {date: Date | string | number; displayFullDate?: boolean}) { | |||
There was a problem hiding this comment.
this should be passed through context, as it should be a global, not a prop passed through many components
| @@ -308,6 +310,16 @@ export function WorkflowsList({match, location, history}: RouteComponentProps<an | |||
| ); | |||
| })} | |||
| </div> | |||
| <label htmlFor='date_format_checkbox'>Show absolute date</label> | |||
There was a problem hiding this comment.
Why should this be isolated to the WorkflowsList page? There are other pages with dates.
In #12943 (comment), I suggested in a global settings page, and also storing that in localStorage, not just temporary state.
agilgur5
changed the title
agilgur5
added
the
problem/more information needed
|
@KillianHmyd - are you going to continue developing this PR? We've got a customer asking for it. If you don't have time to work through it, would you mind if we contributed the PR and had you do a review? |
|
Thanks @KillianHmyd - I really appreciate it |
|
This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs. |
github-actions
bot
added
the
problem/stale
|
This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open. |
|
This was superseded by #13284 |
agilgur5
added
solution/superseded
Fixes #TODO
Motivation
Modifications
Verification