Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump undici, express, follow-redirects, webpack-dev-middleware #12887

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 4, 2024

Bumps the npm_and_yarn group in /ui with 4 updates: express, follow-redirects, undici and webpack-dev-middleware.

Updates express from 4.18.2 to 4.19.2

Release notes

Sourced from express's releases.

4.19.2

What's Changed

Full Changelog: expressjs/express@4.19.1...4.19.2

4.19.1

What's Changed

Full Changelog: expressjs/express@4.19.0...4.19.1

4.19.0

What's Changed

New Contributors

Full Changelog: expressjs/express@4.18.3...4.19.0

4.18.3

Main Changes

Other Changes

... (truncated)

Changelog

Sourced from express's changelog.

4.19.2 / 2024-03-25

  • Improved fix for open redirect allow list bypass

4.19.1 / 2024-03-20

  • Allow passing non-strings to res.location with new encoding handling checks

4.19.0 / 2024-03-20

4.18.3 / 2024-02-29

Commits
  • 04bc627 4.19.2
  • da4d763 Improved fix for open redirect allow list bypass
  • 4f0f6cc 4.19.1
  • a003cfa Allow passing non-strings to res.location with new encoding handling checks f...
  • a1fa90f fixed un-edited version in history.md for 4.19.0
  • 11f2b1d build: fix build due to inconsistent supertest behavior in older versions
  • 084e365 4.19.0
  • 0867302 Prevent open redirect allow list bypass due to encodeurl
  • 567c9c6 Add note on how to update docs for new release (#5541)
  • 69a4cf2 deps: [email protected]
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by wesleytodd, a new releaser for express since your current version.


Updates follow-redirects from 1.15.4 to 1.15.6

Commits
  • 35a517c Release version 1.15.6 of the npm package.
  • c4f847f Drop Proxy-Authorization across hosts.
  • 8526b4a Use GitHub for disclosure.
  • b1677ce Release version 1.15.5 of the npm package.
  • d8914f7 Preserve fragment in responseUrl.
  • See full diff in compare view

Updates undici from 5.28.3 to 5.28.4

Release notes

Sourced from undici's releases.

v5.28.4

⚠️ Security Release ⚠️

Full Changelog: nodejs/undici@v5.28.3...v5.28.4

Commits

Updates webpack-dev-middleware from 5.3.3 to 5.3.4

Release notes

Sourced from webpack-dev-middleware's releases.

v5.3.4

5.3.4 (2024-03-20)

Bug Fixes

  • security: do not allow to read files above (#1779) (189c4ac)
Changelog

Sourced from webpack-dev-middleware's changelog.

5.3.4 (2024-03-20)

Bug Fixes

  • security: do not allow to read files above (#1779) (189c4ac)
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the npm_and_yarn group in /ui with 4 updates: [express](https://github.com/expressjs/express), [follow-redirects](https://github.com/follow-redirects/follow-redirects), [undici](https://github.com/nodejs/undici) and [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware).


Updates `express` from 4.18.2 to 4.19.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.18.2...4.19.2)

Updates `follow-redirects` from 1.15.4 to 1.15.6
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

Updates `undici` from 5.28.3 to 5.28.4
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.28.3...v5.28.4)

Updates `webpack-dev-middleware` from 5.3.3 to 5.3.4
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
  dependency-group: npm_and_yarn-security-group
- dependency-name: follow-redirects
  dependency-type: indirect
  dependency-group: npm_and_yarn-security-group
- dependency-name: undici
  dependency-type: indirect
  dependency-group: npm_and_yarn-security-group
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
  dependency-group: npm_and_yarn-security-group
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies labels Apr 4, 2024
@github-actions github-actions bot enabled auto-merge (squash) April 4, 2024 14:56
@agilgur5 agilgur5 changed the title build(deps): bump the npm_and_yarn group in /ui with 4 updates chore(deps): bump undici, express, follow-redirects, webpack-dev-middleware Apr 4, 2024
@agilgur5
Copy link
Contributor

agilgur5 commented Apr 4, 2024

  1. The chore(deps) didn't seem to apply here, but that might be because ci(deps): use chore(deps) prefix for dependabot commits #12881 got merged at the same time as ci(deps): fix deduplication commit for yarn.lock for Dependabot PRs #12882 and so maybe it hadn't detected it yet.
  2. This added a dep on top of chore(deps): bump express, follow-redirects, and webpack-dev-middleware #12880. That's not a bad thing per se, but the newly added dep is actually prod dep and not a devDep, unlike the others. We'd want to backport/cherry-pick undici to maintained versions but not the rest. Might need to add manual grouping in dependabot.yml?
  3. Guh I had a typo in ci(deps): fix deduplication commit for yarn.lock for Dependabot PRs #12882 (comment) it would seem, and that's why CI is failing here:
    error: unknown option `alow-empty'
    

@agilgur5
Copy link
Contributor

agilgur5 commented Apr 4, 2024

We'd want to backport/cherry-pick undici to maintained versions but not the rest

Oh, actually follow-redirects is both a devDep and a prod dep. Apparently it's used by axios (which is a dep of swagger-api) as well as webpack-dev-server:

❯ yarn why follow-redirects
# [...]
=> Found "[email protected]"
info Reasons this module exists
   - "webpack-dev-server#http-proxy-middleware#http-proxy" depends on it
   - Hoisted from "webpack-dev-server#http-proxy-middleware#http-proxy#follow-redirects"
   - Hoisted from "swagger-ui-react#swagger-client#@swagger-api#apidom-reference#axios#follow-redirects"

So both follow-redirects and undici should get backports, but not express or webpack-dev-middleware, which are exclusively devDeps

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 4, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Apr 4, 2024
auto-merge was automatically disabled April 4, 2024 22:40

Pull request was closed

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ui/npm_and_yarn-security-group-817b3ce182 branch April 4, 2024 22:40
@agilgur5
Copy link
Contributor

agilgur5 commented Apr 4, 2024

Was curious if it would rebase and remove all but undici, but it just closed itself apparently.

For clarity and posterity, this was superseded by #12880 and #12891

@agilgur5 agilgur5 added the solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) label Apr 4, 2024
@agilgur5 agilgur5 changed the title chore(deps): bump undici, express, follow-redirects, webpack-dev-middleware fix(deps): bump undici, express, follow-redirects, webpack-dev-middleware Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript dependencies solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/dependencies PRs and issues specific to updating dependencies type/security Security related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant