Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade swagger-ui-react to latest 4.x.x #12058

Merged

Commits on Oct 21, 2023

  1. chore(deps): upgrade swagger-ui-react to latest 4.x.x

    - there are still some build issues to resolve in order to move to 5.x.x, but in the interim, can move to latest 4.x.x
    - in particular, this upgrade fixes an XSS CVE in a pinned dep of `swagger-ui-react`, `@braintree/santize-url`: https://security.snyk.io/vuln/SNYK-JS-BRAINTREESANITIZEURL-3330766
      - see that it is pinned here, so we could not independently upgrade it without upgrading `swagger-ui-react` itself: https://github.com/argoproj/argo-workflows/blob/5c264c094104645a4c917a9a23615424d564d1e4/ui/yarn.lock#L7702
        - note that it is _still_ pinned in latest 4.x.x of `swagger-ui-react`, but it is at least a newer patch version not susceptible to the CVE
    
    - this adds a lot of new deps, which I am not a fan of, seemingly because it moves to `@swagger` libraries for some behaviors
    - but on the bright side, the actual Swagger UI seems to lag / freeze less and work a little bit better now!
    
    Signed-off-by: Anton Gilgur <[email protected]>
    agilgur5 committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    7c5af9d View commit details
    Browse the repository at this point in the history