Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add FOSSA License Badge for CLOMonitor #12032

Merged

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented Oct 18, 2023

Fixes #9769

Proper version of #12023 that FOSSA made automatically on integration

Motivation

Modifications

  • add FOSSA badge to the README

  • also rename "CII Best Practices" to its new name, "OpenSSF Best Practices"

Verification

Markdown preview looks ok to me

- this is the last non-security check we need for CNCF CLOMonitor
  - after this, all the non-security checks will be at 100%

- note that while we already use Snyk, it actually does not support Go dep badges: https://support.snyk.io/hc/en-us/articles/360003997277-Badge-Support-for-Repositories
  - so use FOSSA, which [Argo CD already uses](https://github.com/argoproj/argo-cd/blob/a9f03aa8ccdafc350b96ee90db054b11cad44692/README.md?plain=1#L11) and is already integrated into Argoproj

- we do also have some license checks to resolve there, I am working on those as well

Signed-off-by: Anton Gilgur <[email protected]>
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Oct 18, 2023
@terrytangyuan terrytangyuan merged commit abf9836 into argoproj:master Oct 20, 2023
21 of 31 checks passed
@agilgur5 agilgur5 deleted the docs-add-fossa-license-badge branch October 20, 2023 03:19
@agilgur5
Copy link
Contributor Author

CLOMonitor non-security checks are now all at 100%!

Screenshot 2023-10-20 at 1 15 03 AM

agilgur5 added a commit that referenced this pull request May 4, 2024
Signed-off-by: Anton Gilgur <[email protected]>
(cherry picked from commit abf9836)
@argoproj argoproj locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring CLOMonitor Score to 100%
2 participants