Skip to content

Commit

Permalink
Mod: Move contextless log messages to debug logging
Browse files Browse the repository at this point in the history
'node changed' 'node unchanged' and 'task-result changed' flood
the logs when running argo in production with many workflows and
parallel runs, move these log statements to debug logging so
that we can filter them
  • Loading branch information
kizzie committed Nov 19, 2024
1 parent 2fd5488 commit 2e3474e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions workflow/controller/operator.go
Original file line number Diff line number Diff line change
Expand Up @@ -1496,11 +1496,11 @@ func (woc *wfOperationCtx) assessNodeStatus(ctx context.Context, pod *apiv1.Pod,
WithField("new.message", new.Message).
WithField("old.progress", old.Progress).
WithField("new.progress", new.Progress).
Info("node changed")
Debug("node changed")
return new
}
woc.log.WithField("nodeID", old.ID).
Info("node unchanged")
Debug("node unchanged")
return nil
}

Expand Down
2 changes: 1 addition & 1 deletion workflow/controller/taskresult.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func (woc *wfOperationCtx) taskResultReconciliation() {
if !reflect.DeepEqual(old, newNode) {
woc.log.
WithField("nodeID", nodeID).
Info("task-result changed")
Debug("task-result changed")
woc.wf.Status.Nodes.Set(nodeID, *newNode)
woc.updated = true
}
Expand Down

0 comments on commit 2e3474e

Please sign in to comment.