Skip to content

Commit

Permalink
docs: remove no longer needed spelling exceptions (#11814)
Browse files Browse the repository at this point in the history
Signed-off-by: Anton Gilgur <[email protected]>
(cherry picked from commit ad34e43)
  • Loading branch information
agilgur5 committed May 4, 2024
1 parent bda056c commit 1dca7f6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 23 deletions.
21 changes: 0 additions & 21 deletions .spelling
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,11 @@ CronWorkflow
CronWorkflows
DataDog
Dataflow
DeleteObject
DevOps
Dex
EditorConfig
EtcD
EventRouter
GSoC
GitOps
Github
Golang
Expand All @@ -74,7 +72,6 @@ InsideBoard
Invocators
IAM-based
Istio
J.P.
Jemison
JetBrains
KNative
Expand All @@ -99,8 +96,6 @@ Node.JS.
OAuth
OAuth2
Okta
parameterize
parameterized
parameterizing
PDBs
PProf
Expand All @@ -119,17 +114,13 @@ Singer.io
Snyk
Sumit
Tekton
Tianchu
Traefik
TripAdvisor
VSCode
Valasek
Webhooks
Welch
`CronTab`
`OnFailure`
a.m.
alexec
anded
apis
architecting
Expand All @@ -138,7 +129,6 @@ args
async
auth
backend
blkperl
boolean
booleans
buildkit
Expand All @@ -147,8 +137,6 @@ config
cpu
cron
daemoned
dev-container
dinever
dockershim
dropdown
e.g.
Expand Down Expand Up @@ -178,8 +166,6 @@ localhost
memoization
memoized
memoizing
mentee
mentees
minikube
mutex
namespace
Expand All @@ -196,15 +182,9 @@ roadmap
runtime
runtimes
sandboxed
sarabala1979
simster7
stateful
stderr
tczhao
terrytangyuan
themself
un-reconciled
untracked
v1
v1.0
v1.1
Expand Down Expand Up @@ -257,5 +237,4 @@ vendored
nix.conf
LDFlags
dev
vendorSha256
dependabot
2 changes: 1 addition & 1 deletion docs/running-nix.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ and replace the existing hash value.
The almost exact same principles apply here, the only difference being you must change the `vendorHash` and the `sha256` fields.
The `vendorHash` is a hash of the vendored dependencies while the `sha256` is for the sources fetched from the `fetchFromGithub` call.

### Why am I getting a vendorSha256 mismatch ?
### Why am I getting a `vendorSha256` mismatch ?

Unfortunately, dependabot is not capable of upgrading flakes automatically, when the go modules are automatically upgraded the
hash of the vendor dependencies changes but this change isn't automatically reflected in the nix file. The `vendorSha256` field that needs to
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/signals_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func (s *SignalsSuite) TestStopBehavior() {
SubmitWorkflow().
WaitForWorkflow(fixtures.ToHaveRunningPod, killDuration).
ShutdownWorkflow(wfv1.ShutdownStrategyStop).
WaitForWorkflow(killDuration + 10*time.Second). // this one takes especially long in CI
WaitForWorkflow(killDuration + 15*time.Second). // this one takes especially long in CI
Then().
ExpectWorkflow(func(t *testing.T, m *metav1.ObjectMeta, status *wfv1.WorkflowStatus) {
assert.Contains(t, []wfv1.WorkflowPhase{wfv1.WorkflowFailed, wfv1.WorkflowError}, status.Phase)
Expand Down

0 comments on commit 1dca7f6

Please sign in to comment.